Attachment default_url should allow nil #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I set `Paperclip::Attachment.default_options[:default_url] = nil` (instead of `missing.png`) Paperclip gives an error. This PR allows setting to nil, without changing any existing behavior.
|
Hi @johnnyshields, thanks for the PR! Your fix looks good, however, one small concern will lead to the following error - So this change will hamper the ability to follow the common pattern of using the If the purpose of this PR is only to render nothing in place of a missing image, maybe, we should avoid returning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I set
Paperclip::Attachment.default_options[:default_url] = nil(instead ofmissing.png) Paperclip gives an error. This PR allows setting to nil, without changing any existing default behavior.